-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Adding Custom Agent Support for fetch call #11400
[typescript] Adding Custom Agent Support for fetch call #11400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, looks good.
Can you please revert the deleted files and update the samples?
yep merging master back in now |
@TiFu are you fine with this change? |
ended up excluding the web fetch since the lib doesn't list agent support, so it's just for the nodejs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the PR! :)
Adding
agent: http.Agent | https.Agent | undefined
instance variable on theRequestContext
class as well as the following methods:Then, the isomorphic fetch implementation would call
getAgent()
to pass the value into theagent
option on thefetch
call inisomorphic-fetch.ts
Implements #11394
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov